Skip to content

Changed hyperparam configuration in the DQN tutorial#3380

Closed
splion-360 wants to merge 3 commits into
pytorch:mainfrom
splion-360:splion-360/rl-qlearning-fixes
Closed

Changed hyperparam configuration in the DQN tutorial#3380
splion-360 wants to merge 3 commits into
pytorch:mainfrom
splion-360:splion-360/rl-qlearning-fixes

Conversation

@splion-360

@splion-360 splion-360 commented Jun 4, 2025

Copy link
Copy Markdown
Contributor

Fixes #3080

Description

  • This PR updates the hyper parameters for the CartPole-v1 environment in the DQN tutorial to better match the results shown in the reference image.
  • A fixed seed has been added to ensure reproducibility of training behavior and evaluation outcomes.

Checklist

  • The issue that is being fixed is referred in the description (see above "Fixes [Improve] - Pytorch Reinforcement DQN Tutorial #3080 ")
  • Only one issue is addressed in this pull request
  • Labels from the issue that this PR is fixing are added to this pull request
  • No unnecessary issues are included into this pull request.

@pytorch-bot

pytorch-bot Bot commented Jun 4, 2025 •
edited
Loading

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3380

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b11054f with merge base 06f9c4b (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions github-actions Bot added docathon-h1-2025 A label for the docathon in H1 2025 medium Reinforcement Learning Issues relating to reinforcement learning tutorials labels Jun 4, 2025
@splion-360 splion-360 closed this Jun 4, 2025
@splion-360 splion-360 reopened this Jun 4, 2025
@sekyondaMeta sekyondaMeta added the skip-link-check Will allow you to skip linkcheck on a PR. Should only should be used when a link can't be fixed. label Jun 4, 2025
@svekars

svekars commented Jun 4, 2025

Copy link
Copy Markdown
Contributor

I believe the only changes should be in the actual DQN tutorial and not in all the other files.

@splion-360

splion-360 commented Jun 4, 2025

Copy link
Copy Markdown
Contributor Author

Thank you @svekars for the feedback. I will work on it

@AlannaBurke

AlannaBurke commented Jun 10, 2025

Copy link
Copy Markdown
Contributor

Any updates to this?

@splion-360 splion-360 closed this Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla signed docathon-h1-2025 A label for the docathon in H1 2025 medium Reinforcement Learning Issues relating to reinforcement learning tutorials skip-link-check Will allow you to skip linkcheck on a PR. Should only should be used when a link can't be fixed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Improve] - Pytorch Reinforcement DQN Tutorial

5 participants

@splion-360 @svekars @AlannaBurke @facebook-github-bot @sekyondaMeta